
Design comparison
Solution retrospective
I want to get better on the front-end development. Any comments or suggestions that help me improve are greatly appreciated.
Please log in to post a comment
Log in with GitHubCommunity feedback
- @MishaHernandez
Hello Nofar Aviv 👋
It looks great, congratulations.
I just have a little remark: in desktop layout the main component has a lot of
margin-top
and this can produce a scroll bar on some screen sizes. So I would recommend removingmargin-top
and usingflexbox
orgrid
to center it horizontally and vertically.body { display: flex; align-items: center; height: 100vh; } @media (min-witdh: 1200px) { container {margin-top: 0; } }
I hope this is helpful to you. Happy coding 🙂
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord