Design comparison
Community feedback
- @HassiaiPosted almost 2 years ago
Replace <div class="container"> with the main tag and <h6></h6> with <p></p> to fix the accessibility issues. give <p> a class for the styling.
To center a content on a page, add min-height:100vh; display: flex; align-items-center: justify-content: center; to the body. Instead of giving the body a margin value.
You forgot to add a media query for the mobile design. In the media query change the width value of .box to 80% 0r 90% , there is no need to give it a height value and give it a flex-direction: column-reverse;
Hope am helpful
Well done for completing this challenge , you did a good job. Happy coding
Marked as helpful1 - @catherineisonlinePosted almost 2 years ago
For the image, I did something like this, I hope that helps:
<div class="image-container"> <img class="main-image" src="images/image-header-mobile.jpg" alt=""> </div> .image-container { display: inherit; position: relative; width: 100%; border-radius: 0 10px 10px 0; background-color: hsl(277, 64%, 61%); } .main-image { width: 100%; height: 100%; position: relative; background-size: cover; border-radius: 0 10px 10px 0; mix-blend-mode: multiply; opacity: 0.75; }
0 - @VCaramesPosted almost 2 years ago
Hey there! π Here are some suggestions to help improve your code:
- To not only improve your HTML code but to also identify the main content of you page, you will want to wrap your entire component inside the
main
element.
More Info:π
- The only heading in this component is the βGet insights that help your business growβ everything else will be wrapped in a
paragraph
element.
- The statistics at the bottom are a list, so it should be built using an
unordered List
element.
More Info:π
MDN <ul>: The Unordered List element
- This challenges requires the use of two images π for different breakpoints. The
picture
element will facilitate this.
Here is an example of how it works: EXAMPLE
Syntax:
<picture> <source media="(min-width: )" srcset=""> <img src="" alt=""> </picture>
More Info:π
https://www.w3schools.com/html/html_images_picture.asp
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding!ππ
0 - To not only improve your HTML code but to also identify the main content of you page, you will want to wrap your entire component inside the
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord