@DivineUgorji
Posted
Congratulations on finishing this challenge🎉 🎉 Your implementation is close to the design.
However, I have a few ideas for improvement on the project.
-
I see that you have different media queries for this project, and I think that is a little bit too much for a simple project such as this. It is generally recommended to always start your projects with the mobile workflow first, then use a media query to make the desktop view, only changing the aspects that need to be changed. This approach helps to enhance responsiveness on mobile views which is important as the majority of users access the web using their mobile devices, it also helps to reduce writing redundant code and repeating yourself many times.
-
I also observed that you used a lot of CSS positioning properties for this project,
flex-grow
andflex-shrink
, which is good, however, that is a lot of tweaking. You can achieve this design and also have it responsive if you move the picture element containing your mobile and desktop images to the top of your HTML structure. Then, use the flexrow-reverse
property in your desktop view to place the image on the right side. -
Set your image height to
auto
in your CSS styles to help it maintain the aspect ratio irrespective of the height of the container which in this case is the picture element. -
Also, the opacity for the images is
0.75
instead of0.3
. This helps you to achieve the right color blend mode for this project. -
I also observed that your flex-group items are smaller than what is provided in the design in the desktop view, please ensure to add a custom style for the flex-group to make them a bit bolder in your desktop view media query.
-
Overall, your solution is good, and I hope these few suggestions help you to improve it even further.
Happy coding, and may the force be with you! 💪
Marked as helpful