@PhoenixDev22
Posted
Hello @NickODxyz,
I have some suggestions regarding your solution:
-
use an unordered list with 3 items for the stats
class="stats". -
numbers don't make sense as
h2s. The number and word have to be read together to make sense so need to be in the same meaningful element. so only aspanor maybestrongtag needs to wrap the numbers. the words likecompaniesshould not be in paragraph tags. They don't need to be wrapped in anything as they are already inside a meaningful element (list item). -
line heights should be unit less like 1.6 not have a unit like
remorem. -
work on the card responsiveness.
Overall your solution is good. Hopefully this feedback helps.
Marked as helpful
@NickODxyz
Posted
@PhoenixDev22 thank you very much for this feedback. These are the things I can really learn from and they make a lot of sense now you point them out.
I've not looked into line-height before and couldn't work out why removing the rem made it so large in some cases. But now I can see why, so thank you for pointing that out to me.
Thanks again for the tips, they're much appreciated.
