Design comparison
SolutionDesign
Solution retrospective
Hi friends, here's another finished challenge: Stats Preview Card Component.
I hope I can count on your valuable feedback so I can improve more and more!
Community feedback
- @AutumnsCodePosted over 1 year ago
Hi there,
it's me again. As i wrote before, your code looks good.
- However, i feel like the media should start earlier. I usually do it at 720px (45rem)
- custom css property(see my other comment)
- The last thing I like to mention and I believe it goes under best-practice whenever you are working with padding and margin:
- whenever the four value is the same, it will be okay when you write it like this
padding: val
- whenever the bottom and top are the same value(val1) and left and right are the same value(val2)
padding: val1 val2
I hope my feeedback is helpful
Marked as helpful0@gabrieltrtPosted over 1 year ago@AutumnsCode Hi Sarah, thanks for your feedback, it will definitely be very useful for me!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord