Design comparison
Solution retrospective
setup flex children with same width
What specific areas of your project would you like help with?-clean code
-best practice
Community feedback
- @R3ygoskiPosted 7 months ago
Hello Oualid, congratulations on completing your project! It's very well done and closely resembles the proposed design.
Regarding your question about clean code and best practices, your project is already quite clean.
Now, regarding best practices, it's always good to use semantic HTML as it improves accessibility and SEO. For example, instead of using
<div class="container">
, you could use<main>
because it represents the main content of your page. Similarly, your<div class="statics">
could be a<ul>
.Another best practice is to use the rem unit to define font sizes. This way, the font adapts to the user's font size settings.
Once again, congratulations on your project! It's very well done. Keep practicing and improving. If anything I said isn't clear, please comment below, and I'll try to help as best as I can.
Marked as helpful0@bennahiaoualidPosted 7 months agothank you so much your advice really what i needed @R3ygoski
1@R3ygoskiPosted 7 months ago@bennahiaoualid No problem at all! I would just like to kindly ask if my comment was helpful and assisted you, could you please mark it as helpful? It would really help me out. Thank you in advance!
0 - @sivaprasath2004Posted 7 months ago
Hello i`ll wishing for your completion project solution.
- I will give some suggestion i believe its used for improve your solution.
- In
mobile
site the.container
pagetop & bottom
page was8rem or 10rem
will be hided use for this code that is more efficient in the mobile site.
@media (max-width:750px) { body{ padding: 8rem 0rem; } }
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord