Stats Preview Card Component

Community feedback

• 

  Elaine•11,400

  @elaineleungPosted 11 months ago

  Hey Dilhan, excellent job here, and it makes me want to go back and clean up some of my old code for this challenge!

  The semantic HTML looks pretty clean to me :) In terms of suggestions, one I could think of would probably be just to add a header tag even though it can be optional, but it would be nice to have since you got a main tag with an h1 in there, and I might put that h1 under header instead. (By the way, what you did with the h1 was also something I did for a lot of these component challenges... I think that's a good idea too!)

  One other thing I saw (which was also something I did in my own solution) was putting the stats in p tags. If I could do that differently now, I would have the stats as an ul list instead, as that might be easier to pick out for users with a screenreader.

  Once again, great work!!

  Marked as helpful

  1

  ---

  

  P

  Dilhan Boca•220

  @dboca93Posted 11 months ago

  Hi Elaine,

  Thanks so much for taking the time to leave some feedback, I appreciate it greatly :)

  All the best !

  1