Design comparison
SolutionDesign
Community feedback
- @frank-itachiPosted over 1 year ago
Hello there ๐. You did a good job!
I have some suggestions about your code that might interest you.
HTML ๐:
- Wrap the page's whole main content in the
<main>
tag. - The heading order is important in the html structure so try to always start your headings and/or titles with an
<h1>
tag and then you can increase by one if you need to use more headings in your html code. - Since the mobile design has a different image, you can use the
<picture>
tag that allows you to interchange the images depending of the viewport size. Red more about this awesome tag here - Make sure that the
<img>
elements in your HTML code has an alternate (descriptive) short text. The reason for this is that screen readers canโt translate images into text. So to fix this you can do the following<img src=โโฆโ alt=โshort textโ >
CSS๐จ:
You can use grid or flexbox to center the content no matter the viewport size. Using grid you can do the following:
body { min-height: 100vh; display: grid; align-items: center; justify-content: center; }
With flex:
body { min-height: 100vh; display: flex; align-items: center; justify-content: center; }
- You can also use the
text-transform: uppercase;
property to make the company word appear in upper case even though you typed it lower cause in the HTML file.
I hope you find it useful! ๐๐ Above all, the solution you submitted is great๐!
Happy
<coding />
๐!Marked as helpful1 - Wrap the page's whole main content in the
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord