Design comparison
Solution retrospective
all feedback is welcome
Community feedback
- @VCaramesPosted about 2 years ago
Hey @michelgx21, some suggestions to improve you code:
-
The statistics section is a list of statistics, so it should be built using an Unordered List along with a List Items Element.
-
Remove all the
<br>
you added. They are not needed. -
You do not want to have or use empty divs in you HTML code, since this is considered to be bad practice. Instead use the Picture Element
Picture Element will allow your to switch between images in different breakpoints
Syntax:
<picture> <source media="(min-width: )" srcset=""> <img src="" alt=""> </picture>
Source:
https://www.w3schools.com/html/html_images_picture.asp
https://web.dev/learn/design/picture-element/
Happy Coding! 👻🎃
Marked as helpful0 -
- @correlucasPosted about 2 years ago
👾Hello @michelgx21, congratulations on your solution!
Nice code and nice solution! You did a good job here putting everything together. I’ve some suggestions for you:
To get closer to
overlay effect
on the photo as the Figma Design its better you usemix-blend-mode
. All you need is thediv
under theimage
with thisbackground-color: hsl(277, 64%, 61%);
and applymix-blend-mode: multiply
andopacity: 80%
on theimg
orpicture
selector to activate the overlay blending the image with the color of the div. See the code bellow:img { mix-blend-mode: multiply; opacity: 80%; }
Here's a good article explaining these effects with mix-blend-mode:
https://developer.mozilla.org/en-US/docs/Web/CSS/mix-blend-mode
✌️ I hope this helps you and happy coding!
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord