Stats preview card component

Community feedback

• 

  Vanza Setia•27,775

  @vanzasetiaPosted about 2 years ago

  Hi, Raymond Fajiculay! 👋

  Good to see you completing another challenge! 👏

  It's great that you keep the specificity of the stylesheet as low as possible. Good job on this! 👍

  One suggestion I have is to not change the html or the :root font size. It can cause huge accessibility implications for those users with different font sizes or zoom requirements. I suggest reading this article by Josh Comeau where he writes about the problem of the 62.5% trick (and more!). Also, I recommend reading what an accessibility expert (Grace Snow) has said about it.

  I hope this helps! Happy coding!

  Marked as helpful

  0

  ---

  

  Raymond Fajiculay•230

  @keyztrokeePosted about 2 years ago

  @vanzasetia Thank you very much, great help

  0

  

  Raymond Fajiculay•230

  @keyztrokeePosted about 2 years ago

  @vanzasetia Hi again, I made some changes, would you mind taking a look if I did it right? Appreciate much. Thank you!

  0

  

  Vanza Setia•27,775

  @vanzasetiaPosted about 2 years ago

  @keyztrokee

  Hello again, Raymond! 👋

  Great job on improving the site! It's good that you are using rem without changing the html font size.

  But, there are two things that you can still do to improve the site.

  • First, use rem unit for the font-size value. I notice the font size for the .attribution is still using px unit.
  • Second, move the font-family to the body element. Most of the text elements such as paragraph and headings will inherit the font family from the body element. Also, since html can overwrite the user's setting, so it's best to use body element instead.

  1

  

  Raymond Fajiculay•230

  @keyztrokeePosted about 2 years ago

  @vanzasetia done, Thank you very much!

  0

  

  Vanza Setia•27,775

  @vanzasetiaPosted about 2 years ago

  @keyztrokee

  Nothing is changed at style.css. The .attribution's font size is still using px unit and the font-family property is still at the html element.

  1

  

  Raymond Fajiculay•230

  @keyztrokeePosted about 2 years ago

  @vanzasetia I change it 19 hours ago and push it to my GitHub but the changes won't show in netlify. Do you know why?

  0

  

  Vanza Setia•27,775

  @vanzasetiaPosted about 2 years ago

  @keyztrokee

  It looks like the CSS is not the latest compiled code. It means that you need to recompile the Sass code. The latest changes in the style/style.scss does move the font-family to the body element.

  1

  

  Raymond Fajiculay•230

  @keyztrokeePosted about 2 years ago

  @vanzasetia thank you!

  1
• 

  バレンタイン 😈•64,170

  @VCaramesPosted about 2 years ago

  **Hey @keyztrokee, your coding has definitely improved since the last challenge.

  Some suggestions to improve you code:

  • The Section Element is being used incorrectly. A simple div will do for this challenge.

  • You want to play around with you media queries. Currently you card, after 800px, gets excessively large until the desktop view kicks in.

  Happy Coding!

  Marked as helpful

  0

  ---

  

  Raymond Fajiculay•230

  @keyztrokeePosted about 2 years ago

  @vcarames Thank you very much, great help

  0

  

  Raymond Fajiculay•230

  @keyztrokeePosted about 2 years ago

  @vcarames Hi again, I made some changes, would you mind taking a look if I did it right? Appreciate much. Thank you!

  0