I'd like to get feedback about my coding practices etc. There are a lot to improve in my coding.
@ruona88
Posted
Hello there,
Your solution looks good. But I noticed there are no media queries for mobile viewing.
@ShehanMaduwantha
Posted
@ruona88 Thank you very much for the feedback. I've included the media queries but they follow the style guide provided. So the breakpoint might be lower than the lowest width the browser can show.
@krisp-dev
Posted
The desktop design looks good overall, it is good practice that you have used relative units throughout your code and the code itself is pretty easy to read for a beginner like myself.
A few minor things I'd touch up on are the font-size (a little bit smaller than the original design) and I'd play around with the filter of the image (contrast and brightness) but I am being really picky here.
Also, I think you forgot to make it mobile responsive.
@ShehanMaduwantha
Posted
@krisp-dev Thank you very much for your feedback. I agree that the font size is a bit smaller than the original design. I included the media query to make it mobile responsive in the _card.scss partial.
Thank you very much for the feedback again !
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord
