Design comparison
Solution retrospective
Hello 👋
On this challenge I used keyframes for the first time. I'm so excited with the infinity possibilits of keyframes.
Improvement suggestion are welcomed!
Community feedback
- @isprutfromuaPosted over 2 years ago
Hi there. You did a good job 😎
keep improving your programming skills🛠️
your solution looks great, however, if you want to improve it, you can fix these points:
✅ Beware of broken box size. Using width with padding can sometimes make elements larger than you expect.
55. padding: 30px 90px 40px 40px;
✅ Disallow duplicate properties. Duplicate property 'flex-wrap' found.
101. flex-wrap: wrap;
✅ Too many font-size declarations (21), abstraction needed.
I hope my feedback will be helpful. You can mark it as useful if so 👍
Good luck and fun coding 🤝⌨️
Marked as helpful1@mateus-lrPosted over 2 years ago@isprutfromua
Hey! Thank you man!
I'll pay more attention on this points, thanks for the feedback! 👍
0@isprutfromuaPosted over 2 years ago@mateus-lr I'm glad that my comment was helpful to you. You can also contact me if you have any questions
Cheers
0@mateus-lrPosted over 2 years ago@isprutfromua Hello!
I need your help, I finished another challenge and again I have too many font-size. You said to me to do abstraction. Do you know where can I learn more about solutions to reduce the number of font-size?
thank you!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord