Marcia• 90
@marciabel
Posted
Hey ! Great work. I noticed a couple of thing that may help improve your code.
- First of all, a small thing, when naming classes in CSS, I believe the convention is to use hyphen-separated words, also known as khebab case(
something-like-this), instead of using underscores or snake_case (something_like_this). Even if you decide to use snake_case, you should only use one '_', not two, to separate words. It will compile regardless, but that's the general convention. - Another thing is that when you go down in the size of the screen, like let's say a screen of 1100 width, I would size down the space between the card and the border so the image doesn't have to suffer it. Then in tablet and phone size, when you go down there's a point where you have no space between the card and the border of the screen, so maybe that's something to look out for the future.
Marked as helpful
1
