Stats preview card component

Community feedback

• 

  Vas•110

  @VasJMPosted almost 2 years ago

  Hello, Felipe! 👋 This is a beautiful solution, but one critical error that is affecting the responsiveness of your project is the use of px instead of em. For CSS properties like margin, margin-*, padding, padding-*, width, *-width, height, *-height, and when defining media queries, it is recommended to use relative units like em instead of px which is an absolute unit. I would also suggest not setting a fixed width to your container, and instead use max-width, because changing my default browser font-size to 20px breaks your page, causing the text to overflow the card because you have given it a fixed size. Assuming you know how to convert px to em, your width: 1111px should be max-width: 69.4375em, and if you set a max-width you don't have to set a max-height. Similar px to em conversions need to made to the necessary CSS properties I mentioned above. I hope this makes sense!

  Another little problem, theREADME.md file used in your GitHub repo is the one provided my Frontend Mentor and not your personal one which is the README-template.md file. You have to edit the template file as needed and then rename it (to README.md) after deleting the one provided by FEM!

  I hope I have been of some help, Felipe! Feel free to reach out if you need me to expand on or clarify anything I said, or even if you need assistance with something else 😊

  1

  ---

  

  Felipe Godoy•200

  @FelipeGodoy1Posted almost 2 years ago

  @VasJM Hello Vas, I appreciate your feedback. I will address the suggested layout improvements as soon as possible, converting the fixed px sizes to em and adjusting the README.

  0