Stats preview card

Community feedback

• 

  Vanza Setia•27,775

  @vanzasetiaPosted almost 2 years ago

  Hi, Luis!

  First, I recommend using a code-formatter. This way, your code base will have a consistent format which makes it easier to read the code. I suggest using Prettier as your code-formatter.

  Prettier · Opinionated Code Formatter

  Here are some suggestions for improvements.

  • Add media attribute to the <source>. Currently, the browsers that support <picture> element will always use the image on the <source>. The behavior that should happen is to use the image-header-mobile.jpg for mobile users and use images/image-header-desktop.jpg for desktop users.
  • For the <div class="info">, make it as a list instead (<ul>). This content is more appropriate to be a list of three bullet items.
  • Avoid using px unit for font sizes. Use rem or em instead. Relative units such as rem and em can adapt when the users change the browser's font size setting.

  I hope this helps.

  Marked as helpful

  0