Design comparison
SolutionDesign
Solution retrospective
I would like your Feedback, to correct something that is messy or wrong in my code and to have a different point of view to aggregate in my knowledge. Thank you in advance. 🙏🙏🙏
Community feedback
- @vanzasetiaPosted over 3 years ago
👋Hi Yohan-Marques!
I have some feedback on this solution:
- I have a recommendation on selecting element on CSS, instead of writing something like this, which is the increasing the specificity unnecessarily.
p.text-1 { color: hsla(0, 0%, 100%, 0.6); padding-top: 30px; padding-right: 50px; line-height: 2; font-size: 14px; }
- Try to select it like this:
.text-1 { color: hsla(0, 0%, 100%, 0.6); padding-top: 30px; padding-right: 50px; line-height: 2; font-size: 14px; }
- That is also apply on
div.conten
anddiv.photo
. - Try to use
rem
unit, since it will allow the user to change theirfont-size
based on their setting. - Try to add
padding
on your body to prevent the card to fill all screen on mobile screen size (<400px width).
That's it! Hopefully this is helpful!
3
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord