HTML5, CSS

Community feedback

• 

  Eugenia•950

  @JaneMorozPosted almost 2 years ago

  Hey! Congrats 🎉 Your solution to this challenge is great! ❤️

  The only things I've noticed:

  • You need to wrap the main content of the page into the <main> tag. It will solve all these landmark issues and improve accessibility.
  • Also when I make it smaller, the card image body is kinda cut in half. You have height: 100vh;so I suggest to it change min-height: 100vh; and maybe add some top and bottom margins to card. This way you card will still be centred for larger screens and not cut from above for smaller screens.

  Keep it up! And good luck 🍀

  Marked as helpful

  0