Design comparison
SolutionDesign
Solution retrospective
Hi! I've solved this challenge using flex and used sass as a dev-dependency. I might have made it overly complicated with the media queries. Would love to get some feedback on how I could use flex with background images, and how the sizing can be modified according to the parent container for the image.
Thanks a lot!
Community feedback
- @anoshaahmedPosted almost 3 years ago
To avoid accessibility issues in the future, wrap everything in your body in
<main>
OR giverole=""
to the direct children of your<body>
... Click here to read moreGood job! :)
Marked as helpful0 - @skyv26Posted almost 3 years ago
Hi! Neha,
To solve accessibility issues:
- Change your be below code
<div class="attribution"> Challenge by <a href="https://www.frontendmentor.io?ref=challenge" target="_blank">Frontend Mentor</a>. Coded by <a href="https://github.com/nehanandi09" target="_blank" rel="noopener noreferrer">Neha Nandi</a>. </div>
To
<footer class="attribution"> Challenge by <a href="https://www.frontendmentor.io?ref=challenge" target="_blank">Frontend Mentor</a>. Coded by <a href="https://github.com/nehanandi09" target="_blank" rel="noopener noreferrer">Neha Nandi</a>. </footer>
Best OF Luck ;)
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord