Design comparison
Community feedback
- @HassiaiPosted almost 2 years ago
Replace <div id="card"> with the main tag and <h2> with <h1> to fix the accessibility issues. for more on semantic html visit https://web.dev/learn/html/semantic-html/. There is no need for the <br> before the <img>. I will advise you wrap the <img> in a div and give it a class for the styling: e.g: <div class= "content_img"><img></div>. in the css , give .content_img a backgroud-color of soft-voilet. and a width of 50%.
Use the colors that were given in the styleguide.md found in the zip folder you downloaded.
To center #card on the page, add min-height:100vh; display: flex; align-items: center: justify-content: center; or min-height:100vh; display: grid place-items: center to the body.
Give #header a max-width of 100%, mix-blend-mode: multiply; opacity of 0.7 or higher. instead of giving it a filter value.
Use rem or em as unit for the padding, margin, width and preferably rem for the font-size for more on this watch this https://youtu.be/N5wpD9Ov_To
Hope am helpful HAPPY CODING
Marked as helpful1@faissal-aLPosted almost 2 years ago@Hassiai Thank you for your insight, I will correct my code as soon as I can
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord