Design comparison
Solution retrospective
Here is my second project, I just started to learn the code and I need your advice ;) If you have answers to my questions thank you. I think I've done the project pretty well and it's quite responsive. All your comments are welcome.
Community feedback
- @rubbersoulsPosted almost 3 years ago
Hello Here is my second training exercise, I am a beginner in code. I have several questions about my code:
-I was reproached for putting the functions: display: flex; / align-items:center; / justify-content: center; in my body with the aim of centering my <section> To solve the problem I can use margin:auto in my section, but how to vertically center it?
-I have another question: how do I make an element take that many % of the div it's in? For example in my <div .box> I have two <div> and I would like one <div> to take 55% of .box and the other 45%. When I put a %, it's not based on the div the object is in, so what do I do with the object is that my div automatically scales to the size of my < section>? :D
-I have also been criticized for giving the height and width of my divs in px, is this really a problem? Because I have trouble with other measurement units so I only use the px unit.
-I don't understand the site's criticisms of accessibility? I have a <section> and the language indicated.
-And finally :) how to find the right fonts used in the models? If you have any advice.
-If you have any other remarks in my code, I am interested in the objective and to improve myself;) thank you
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord