Design comparison
Community feedback
- @CodeWithAlaminPosted almost 2 years ago
Hi Lia Smithπ Great job on completing this challenge! π₯³
I would like to share a few suggestions on this solution if you don't mind.
-
Add
alt
attributes to your image elements: Currently, your image elements do not havealt
attributes. Thealt
attribute provides a text alternative for an image, which can be read by screen readers and is useful for users who are unable to see the image. To improve accessibility, you should addalt
attributes to your image elements to provide a brief, descriptive text alternative for the images. -
Use semantic HTML elements: To improve the accessibility and usability of your webpage, you should use semantic HTML elements to structure your content. Semantic elements give meaning to the content they contain, which can help screen readers and other assistive technologies understand the purpose and structure of the content. Using semantic elements will also make your code easier to read and understand for other developers.
-
Use relative units for font sizes: Currently, you are using fixed pixel values for font sizes in your CSS. To make your webpage more responsive, you should consider using relative units for font sizes, such as
em
orrem
, instead of pixels. This will allow the font sizes to scale more easily based on the size of the user's device or browser window.
For example:
body { font-size: 16px; } h1 { font-size: 2em; /* equivalent to 32px */ } p { font-size: 0.875rem; /* equivalent to 14px */ }
Overall, this is a very well done solution to the challenge. Great job!
I hope this feedback was helpful. π Keep up the good work!π
Marked as helpful1 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord