Stats preview card component

Community feedback

• 

  Divine Ugorji•350

  @DivineUgorjiPosted about 1 year ago

  Congratulations on finishing this challenge. Your implementation is close to the design.

  However, I have a few ideas for improvement on the project.

  • As you pointed out, your solution is not responsive on mobile. It’s always encouraged to start your projects from the mobile workflow first, then use media query for the desktop screen. This approach helps to enhance responsiveness on mobile views which is important as the majority of users access the web using their mobile devices.

  • You can use a picture tag as a container for the two images provided for both the mobile and desktop view for this project instead of wrapping the images in two separate div containers.

  • Also, the opacity for the images is 0.75 instead of 0.3. This helps you to achieve the right color blend mode for this project.

  • Ensure to move the attribution styles from your HTML file to your CSS file. It helps to make your code more organized.

  • I also observed that you do not have a custom Readme page for your project on GitHub. It’s always a good practice to have a custom Readme for your projects, using the Readme template provided as a guide. The readme page is a good way to document your project and helps for future contributions on the project.

  • Overall, your solution is good, and I hope these few suggestions help you to improve it even further.

  Happy coding!

  Marked as helpful

  1