Stats preview card component

Community feedback

• 

  P

  visualdennis•8,375

  @visualdennissPosted over 1 year ago

  Hey there,

  your solution looks good overall! But there seems to be an issue with empty space on mobile, because you are using height: 140%, which might cause issues with changing screen-sizes. So instead simply u can use min-height: 100vh; e.g.

  html, body { height: 100%; min-height: 100vh; }

  and make height: 100%; for the main.

  Also try to avoid giving a fixed height like height: 200px; as this will cause accessibility issues when the container contains some text element. Content with overflow, if the user decides to have bigger font-size to read. Finally avoid using px as much as possible, instead use rem or em. Here is a great resource on YT: https://www.youtube.com/watch?v=dHbYcAncAgQ

  Hope you find this feedback helpful!

  Marked as helpful

  0
• 

  Hassia Issah•50,650

  @HassiaiPosted over 1 year ago

  There is no need to give the main a min-width.

  To center .card on the page using flexbox, replace the height in the body with min-height: 100vh.

  For the color of the image there is no need for linear-gradient in .hero-container rather give a background-blend-mode of multiply, a background-color of soft violet and opacity:0.8.

  .hero-container{
  background-image: url();
  background-size: cover;
  background-color: hsl()
  background-blend-mode: multiply;
  opacity: 0.8;
  }
  

  give .card a width of 80vw or max-width:1440px and width 80% for a responsive content.

  Hope am helpful.

  Well done for completing this challenge. HAPPY CODING

  Marked as helpful

  0