@visualdenniss
Posted
Hey there,
your solution looks good overall! But there seems to be an issue with empty space on mobile, because you are using height: 140%, which might cause issues with changing screen-sizes. So instead simply u can use min-height: 100vh; e.g.
html, body { height: 100%; min-height: 100vh; }
and make height: 100%; for the main.
Also try to avoid giving a fixed height like height: 200px; as this will cause accessibility issues when the container contains some text element. Content with overflow, if the user decides to have bigger font-size to read. Finally avoid using px as much as possible, instead use rem or em. Here is a great resource on YT: https://www.youtube.com/watch?v=dHbYcAncAgQ
Hope you find this feedback helpful!
Marked as helpful