Design comparison
Community feedback
- @HassiaiPosted over 1 year ago
Replace <div class="container"> with the main tag , <h2> with <h1> to make the content/page accessible. click here for more on web-accessibility and semantic html
Every html must have <h1> to make it accessible. Always begin the heading of the html with <h1> tag wrap the sub-heading of <h1> in <h2> tag, wrap the sub-heading of <h2> in <h3> this continues until <h6>, never skip a level of a heading.
Give the alt attribute in the img a value. The value of the alt attribute is the description of the image. For decorative images like icons, there is no need to give it an alt value, for more on alt attribute Click here.
Use the colors that were given in the styleguide.md found in the zip folder you downloaded.
To center .container on the page using flexbox or grid:
- USING FLEXBOX: add min-height:100vh; display: flex; align-items: center: justify-content: center; to the body
body{ min-height: 100vh; display: flex; align-items: center; justify-content: center; }
- USING GRID: add min-height:100vh; display: grid place-items: center to the body
body{ min-height: 100vh; display: grid; place-items: center; }
Give .container a width of 80vw or a max-width of 1440px and width of 80% for a responsive content and add display: flex to it.
For the color of the image, give .img-container a background-color of soft violet and give the img a width and height of 100%, mix-blend-mode: multiply and opacity:0.8.
.img-container{ background-color: hsl(); } img{ width: 100%; height: 100%; object-fit: cover; mix-blend-mode: multiply; opacity: 0.8; }
in the desktop design give .card-1 and .img-container a width of 50% and in the media query give them a width of 100%
Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here
Hope am helpful.
Well done for completing this challenge. HAPPY CODING
Marked as helpful1@JulizajzPosted over 1 year agoThank you for your feedback! I was very unsure of my html layout and didn't like how it looked in the end but I wasn't exactly sure what to fix. So this is really helpful. Thanks! @Hassiai
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord