Stats preview card component

Community feedback

• 

  Hana•960

  @Hanka8Posted over 2 years ago

  Hi leverh, nice job!

  You wrongly placed the end of the </div> in your html (you meant it under the attribution?) - I think its the root of your problems.

  I would place the attribution outside of the main section, and create a separate footer containing it. Then, you should remove "display: flex" and "align-items:center" from the body tag and place them in the .main tag. This way your footer will appear at the end at all screen-sizes and will be not affected by the flexbox.

  Also, you should remove .card {"margin-top: 18rem"} and .main {"height:100vh} from your media (this crops your content only on the height of mobile screen).

  Suggestions for accesibility:

  • instead of <section class="main>, use just <main> tag;

  Hope this helps!

  0

  ---

  

  leverh•300

  @leverhPosted over 2 years ago

  @Hanka8 Thank you very much for your tips. I fixed it! :)

  0