Design comparison
Solution retrospective
kindly check out my project and tell me more on how to improve
Community feedback
- @HassiaiPosted almost 2 years ago
Replace<section class="container">with the main tag and <div class="attribution"> with the footer tag to fix the accessibility issues. click here for more on web-accessibility and semantic html
For the color of the image, there is no need for a linear gradient .card_img, Add a background color of soft violet, a background-blend-mode of multiply and opacity of 0.8 to .card_img.
.card_img{ background-image: url(); background-size: cover; background-color: hsl() background-blend-mode: multiply; opacity: 0.8; }
The font-weight of .numbers should be bolder.
To center .card-container page, add min-height:100vh; display: flex; align-items: center: justify-content: center; or min-height:100vh; display: grid place-items: center to.container.
To center .card-container on the page using flexbox: body{ min-height: 100vh; display: flex; align-items: center; justify-content: center; }
To center .card-container on the page using grid: body{ min-height: 100vh; display: grid; place-items: center; }
Hope am helpful.
Well done for completing this challenge. HAPPY CODING
Marked as helpful0 - @victorebegbunaPosted almost 2 years ago
Nice work. Just some little adjustment. Take note of the font type, and also let the "help" in the bold title come up to the first line so it appears more like the original.
Marked as helpful0 - @VCaramesPosted almost 2 years ago
Hey there! 👋 Here are some suggestions to help improve your code:
- The
section
element is being used incorrectly ⚠️ and not needed for this challenge .
- The statistics at the bottom are a list ⚠️, so it should be built using an
unordered List
element.
More Info: 📚
MDN <ul>: The Unordered List element
- Your
CSS Reset
is being underutilized. 😢 To fully maximize 💯 it, you will want to add more to it. Here are some examples that you can freely use 😁: Josh Comeau Reset Eric Meyer Reset
- The incorrect ❌
font-family
is being used. Check you "style-guide" to download the correct one.
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding! 🎆🎊🪅
0@Babsman123Posted almost 2 years ago@vcarames must the statistics buttons be built with <ul>?
0@VCaramesPosted almost 2 years ago@Babsman123
Technically you don’t. There’s many ways you can accomplish the statistics;
- "ok" =
- "good" =
- "best" = built with a list
0 - The
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord