Stats preview card component

Community feedback

• 

  Zubair Abid•280

  @ZubairAbid101Posted over 1 year ago

  Hello!!!

  Congratulations on completing the challenge!

  There are some things that you can improve in the code,

  • It seems that the <img> element does not appear for layouts between the desktop and mobile layout. I advise creating two <img> elements, one for desktop and the other for mobile design. Then set the display: none for the mobile <img> element. Using media queries set the display: block when the screen size is that for a mobile layout.
  • Try to use media queries within each element rather than creating a singular media query for all the elements.
  • Rather than using height: 100vh try using min-height: 100vh.
  • CSS Grid is a good way to format the layout so to speak but for single column or single row layouts try using display display: flex

  I hope you find this comment helpful!

  Did you know that there's a mark as helpful and an up-vote option?

  There's even a Follow button!!!

  Happy Coding!!!

  Marked as helpful

  1

  ---

  

  lastiwan89•260

  @lastiwan89Posted over 1 year ago

  maybe in the next project i fix it. thank you @ZubairAbid101 You can see my solution here: https://www.frontendmentor.io/solutions/product-preview-card-component-0BveRRibkW

  0