Design comparison
SolutionDesign
Community feedback
- @RubylenshyPosted about 2 years ago
Hi @Girishbanua, congratulations on completing this challenge, nice work you have done here. Here are a few suggestions on the accessibility of your code:
- Your <div class="main-card"></div> should be wrapped in a <main></main> tag for easy recognition by the any web browser, it stands out as the main content of the webpage according to markup rules.
- How about using an external stylesheet, how cool and neat could that be? You should try it out.
- And you could make your class="attribution" a footer tag instead of a div if you wish.
Great Work @Girishbanua, Keep Coding
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord