Design comparison
Solution retrospective
Still getting used to working with media queries to build responsive websites. Would appreciate any advice to make the code more efficient.
Community feedback
- @besttlookkPosted over 2 years ago
Hi, Apart from the above suggestions i like to point out that try to use some wrapper which avoid the content to touch the boundry of the screen. When you design something inspect it for all screen size. You can wrap your card with the following code"
.wrapper{ width:90vw; max-width: 780px; // change it accoring to your needs. margin: 0 auto; // to center padding: 0 1rem; }
Good luck, Happy Coding
1 - @isprutfromuaPosted over 2 years ago
Hi there. You did a good job 😎
keep improving your programming skills🛠️
your solution looks great, however, if you want to improve it, you can follow these steps:
✅ Button states are important, not just button styling (focus, focus-within)! If you are only toggling classes to visually manage state of your components, you are likely not appropriately conveying that state to users of assistive technologies.
✅ Use relative units for font size, such as ems or rems. While modern browsers can smoothly zoom pixel-based layouts, sizing type in relative units ensures an entire layout can be scaled up or down by simply updating the font-size of the body element.
✅ You Need to Stop Targeting Tags in CSS. When you add CSS directly on tags, your markup can’t change. Your style is tightly coupled to your DOM, and any change increases the risk of breaking things.
I hope my feedback will be helpful. You can mark it as useful if so 👍
Good luck and fun coding 🤝⌨️
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord