Stats preview card component

Community feedback

• 

  Dusan•700

  @DEmanderbagPosted over 3 years ago

  Hey, Soransh great submission.

  This is what I would change. Your tablet/desktop view is not full screen. With your current code as it is try adding display flex on the body element with flex-direction column and with justify-content and align-items center.

  The image is also creating some space at the bottom and in other to resolve that you can use width and height on an image tag of 100% so it can grow as much as the parent element in your case div with a class of image. But after that image can look distorted and in other to resolve that you can use object-fit: cover again on the same image tag.

  Would suggest checking Perfectly Sized Images

  1

  ---

  

  soransh singh•1,025

  @soransh-singhPosted over 3 years ago

  @DEmanderbag thanks for the feedback, I am going to apply all the suggestion you have given. thankss...

  1

  

  Dusan•700

  @DEmanderbagPosted over 3 years ago

  @soransh-singh You're welcome, I've totally forgot to mention that your content div should be flex and the content__list class should have margin-top auto in other to go all the way to the bottom of a parent. You can check A Complete Guide to Flexbox to get a better understanding.

  Keep on coding it takes practice but the more you do the better you will become ^^

  1

  

  soransh singh•1,025

  @soransh-singhPosted over 3 years ago

  @DEmanderbag I have applied your above suggestions and added flex to body and thanks for feedback. BTW: I open your personal website and it really looks cool.

  0

  

  Dusan•700

  @DEmanderbagPosted over 3 years ago

  @soransh-singh Excellent, glad that I was able to help you.

  Thank you as well, that website and projects inside helped me get my first job. So I'm beyond grateful for this website and the amazing projects that we can find here.

  0