Design comparison
Solution retrospective
Hi Iโm Brijeshkumar and this is my solution for this challenge.
Any suggestions on how I can improve and reduce unnecessary code are welcome!
Thank you. ๐
Community feedback
- @Kamasah-DicksonPosted over 1 year ago
Hello there, you are really doing a great there but these are a few things that I noticed .
- I realized your card is not responsive. use a max-width property instead of just width. the width property on the main behaves like a block element which may cause overflows sometimes.
- I noticed you are using floats to layout your card which makes it unresponsive. Avoid using floats. always use responsive layout systems like flexbox and grid.
- You missed some of the background properties like the background-position
I think you did a really great job.๐ฅ Happy coding๐
0@brijeshkumar001Posted over 1 year ago@Kamasah-Dickson Hello! Thank you for your feedback and for pointing out those issues with the code. I'll make sure to use max-width instead of width and consider using responsive layout systems like flexbox and grid in the future to improve the responsiveness of the card. Also, thanks for reminding me about the background-position property, I'll make sure to include it when needed. I appreciate your kind words and encouragement, and I'll continue to work hard on my coding skills. Let me know if you have any other suggestions or feedback!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord