Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Stats preview card component

@PBalazs0517

Desktop design screenshot for the Stats preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

Alamin 2,000

@CodePapa360

Posted

Hi Péter Balázs👋 Great job on completing this challenge! 🥳

Overall, the code looks good and the webpage appears to be functioning as intended. However, there are a few things that can be improved to make the code more efficient and maintainable:

  • Use semantic HTML elements: Instead of using div elements for everything, consider using more semantic HTML elements such as header, main, section, article, aside, and footer to better convey the meaning and purpose of the different parts of the webpage. For example, the stats element could be an aside element, and the card element could be a section.

  • Use BEM (Block Element Modifier) methodology for class names: BEM is a naming convention for CSS class names that helps to prevent naming conflicts and makes the code more readable and maintainable. Instead of using multiple classes with hyphens (e.g. stats | text-center align-center-sm-only), consider using BEM syntax where the block is separated from the element by a double underscore (__) and the modifier is separated from the block or element by a single underscore (_).

Overall, this is a very well done solution to the challenge. Great job!

I hope this feedback was helpful. 😊 Keep up the good work!👍

Marked as helpful

0

@PBalazs0517

Posted

@CodePapa360 Thank you for the feed back!

0
Alamin 2,000

@CodePapa360

Posted

@PBalazs0517 Your are welcome!!

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord