Stats preview card component

Community feedback

• 

  Alamin•2,000

  @CodeWithAlaminPosted almost 2 years ago

  Hi Péter Balázs👋 Great job on completing this challenge! 🥳

  Overall, the code looks good and the webpage appears to be functioning as intended. However, there are a few things that can be improved to make the code more efficient and maintainable:

  • Use semantic HTML elements: Instead of using div elements for everything, consider using more semantic HTML elements such as header, main, section, article, aside, and footer to better convey the meaning and purpose of the different parts of the webpage. For example, the stats element could be an aside element, and the card element could be a section.

  • Use BEM (Block Element Modifier) methodology for class names: BEM is a naming convention for CSS class names that helps to prevent naming conflicts and makes the code more readable and maintainable. Instead of using multiple classes with hyphens (e.g. stats | text-center align-center-sm-only), consider using BEM syntax where the block is separated from the element by a double underscore (__) and the modifier is separated from the block or element by a single underscore (_).

  Overall, this is a very well done solution to the challenge. Great job!

  I hope this feedback was helpful. 😊 Keep up the good work!👍

  Marked as helpful

  0

  ---

  

  Péter Balázs•130

  @PBalazs0517Posted almost 2 years ago

  @CodePapa360 Thank you for the feed back!

  0

  

  Alamin•2,000

  @CodeWithAlaminPosted almost 2 years ago

  @PBalazs0517 Your are welcome!!

  0