Design comparison
Solution retrospective
Hello, I worked a lot at this challenge, and I'm curious what is your opinion about what I did. Feel free to leave your comment. Thanks :)
Community feedback
- @correlucasPosted about 2 years ago
👾Hello @yuki6464, congratulations on your solution!
Nice code and nice solution! You did a good job here putting everything together. I’ve some suggestions for you:
1.To get closer to
overlay effect
on the photo as the Figma Design its better you usemix-blend-mode
. All you need is thediv
under theimage
with thisbackground-color: hsl(277, 64%, 61%);
and applymix-blend-mode: multiply
andopacity: 80%
on theimg
orpicture
selector to activate the overlay blending the image with the color of the div. See the code bellow:img { mix-blend-mode: multiply; opacity: 80%; }
Here's a good article explaining these effects with mix-blend-mode:
https://developer.mozilla.org/en-US/docs/Web/CSS/mix-blend-mode
2.A better way to work this solution image, the product image is by using
<picture>
to wrap it on the html instead of using it as<img>
orbackground-image
(with the css). Using<picture>
you wrap both images (desktop and mobile) and have more control over it, since you can set in the html when the images changes setting the screen size for each image.ote that for SEO / search engine reasons isn’t a better practice import this product image with CSS since this will make it harder to the image.Here’s the documentation and the guide to use this tag:
https://www.w3schools.com/tags/tag_picture.asp
✌️ I hope this helps you and happy coding!
Marked as helpful0@yuki6464Posted about 2 years ago@correlucas thank you so much for your reply is good to know :)
0 - @vanzasetiaPosted about 2 years ago
Hi, Yuki! 👋
Congratulations on finishing this challenge! 🎉
For the
image-header
, I recommend usingpicture
element. This way, you can control which image should show up based on themedia
condition.The font family of the page is only "Lexend Deca". The Inter font family gets overridden.
body { font-family: 'Inter', sans-serif; font-family: 'Lexend Deca', sans-serif; }
So, you need to apply the other font family in specific elements. See the
style-guide.md
to know about it.That's it! I hope this helps!
Marked as helpful0@yuki6464Posted about 2 years ago@vanzasetia thank you for leaving a comment, and for your help, I will use what you left in the comment :) have a great day.
0@vanzasetiaPosted about 2 years ago@yuki6464 You are welcome! Have a nice day! 👍
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord