@PhoenixDev22
Posted
Greeting Jay, Congratulation on completing another frontend mentor project . Your solution looks nice.`
-
There should be two landmark components as children of the body element - a main (which will be the component) and a footer (which will be the attribution). -You're misusing section element, section is for a bigger chunk of content often titled by
<h2>
.Just a main element for the component and a footer for the attributionread more about sections.Instead, make the card a main and use`< div>``s for the two halves inside it -
Numbers don't make sense as
<h2>
s. -
The number and word have to be read together to make sense so need to be in the same meaningful element. so only a span or maybe strong tag needs to wrap the numbers. (You can set those to be display block via a class).
-
You can apply border radius, display flex and overflow hidden to the component. It would be column-reverse for mobile and row for desktop.
-
Don’t do widths in % or you will lose control of the layout. . Instead use
max width
inrem
consider using max-width. That will let the component grow up to a point and be limited. -
Use an unordered list
<ul>
with 3 items for the stats. -
Use
min height
on the background image half.
Hopefully this feedback helps. Keep coding !
Marked as helpful