Design comparison
SolutionDesign
Solution retrospective
Please may I have feedback, I am a beginner and all the help is appreciated. Thanks
Community feedback
- @kens-visualsPosted about 3 years ago
Hey @iduaine12 👋🏻
I've got some tips to help you fix the accessibility issues and some minor things.
- First, I suggest replacing
<div class="container">...</div>
should be<main class="container">...</main>
. And this will fix the accessibility issues. But, don't forget to generate a new repot once you fix the issues. - Next, instead of giving separate
border-radius
es to each corner, I suggest getting rid of them all and add this lineoverflow: hidden;
in.container
I hope this was helpful 👨🏻💻 you've made great progress on the second project, keep it up. Cheers 👾
Marked as helpful1 - First, I suggest replacing
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord