Design comparison
Solution retrospective
Looking for valuable feedback, and a suggestion for the mistake at the right bottom side of the card.
Community feedback
- @kushyzeePosted over 3 years ago
I have gone through your code and I have the following suggestions
-
Remove the
style
tag from your css file, it's a html tag and has no business in css. -
Your
<div class="context">
is missing a closing div tag. -
Consider removing the height from
.context
, instead you should allow the contents to determine the height (which you can manipulate by using margins and paddings. Also don't use px in the width property, use % instead so as to make the site responsive across different screen size (90% will suffice in this case). -
The line height on the h1 property is too much. Consider reducing it
-
The image was supposed to be used as a
background-image
and not as a direct image in html file. But I guess that's what works for you
There are a bunch of other things you could have done differently, I can't exactly get into it right now without changing the entire code
0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord