Design comparison
SolutionDesign
Solution retrospective
Any feedback is much appreciated
Community feedback
- @Jos02378Posted over 3 years ago
Hi @MohamedHussein05, awesome work on this solution!
Some suggestions for you:
- You can try to follow a CSS naming convention called BEM. You can watch this video for more information link to video.
- I don't recommend using em unit for font size because it can get tricky if there is deep nesting, you can try to use another unit called rem. Here is a link to an article that explains when to use which unit link to Article
I hope this helps, good luck!
0@MohamedHussein05Posted over 3 years agoThanks @Jos02378 for you feedback, I'll try to implement your suggestions in next challenge
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord