Design comparison
SolutionDesign
Community feedback
- @Yemisrach15Posted over 3 years ago
Hey Ahmed
Good job! As the viewport width is decreased, the text in
.stat-container
overflows. You can correct it like this- Remove the
height
property both from.card
and.image
. This will enable the text in.stat-container
to be included within the main card. - On
.image
settingbackground-repeat: no-repeat;
background-size: cover;
will make the image the same height as thediv
on the left side of it.
1@aabdulbassetPosted over 3 years ago@Yemisrach15 Hello, thanks for the feedback.
I applied the fixes but faced the following issues:
-
I had to set an image height on mobile because for some reason it won't display without it.
-
I think the text overflow is still not fixed, and I can't figure out why.
I applied the changes to my GitHub. Thanks.
1@Yemisrach15Posted over 3 years ago@ahman41
- Yeah I also had to set height on the image for mobile. I'm sure there are other ways though. (Not that this is wrong)
- Text overflow is fixed from what I see🙂
And you're welcome
0 - Remove the
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord