Stats card - HTML, SASS, Flexbox, BEM

Community feedback

• 

  Raymart Pamplona•16,100

  @pikapikamartPosted over 3 years ago

  Hey, great work on this one. The layout in desktop is good as well in mobile.

  Suggestion/s would be that

  • Personal preference. I suggest not using height: 100vh on a main component. Since you are limiting only based on the viewport's height. Instead of this, use some other units like rem , so that it won't scale according to the viewport. Then just adding some paddings in the top and bottom in the .container selector. I suggested it because when you open up dev tools at the bottom, your layout is being pushed in the top and can't be scrolled.

  Also removing that height: 100vh will make the attribution properly in the flow. Even if the height is small, it won't go up like it is doing now.

  Other than it is all good. One more thing, why did you use spam in the markup :>>

  1

  ---

  

  Juan Bonilla•610

  @juanpb96Posted over 3 years ago

  @pikamart thanks for commenting on my solution!

  I haven't tried usign dev tools at the bottom so this issue with scaling according to the viewport is new for me. I've taken your suggestion and fixed this problem usign rem.

  I didn't notice that m hahaha, so I changed spam with span.

  1