Stats card component

Community feedback

• 

  Oludayo DS•100

  @multidamsyPosted over 3 years ago

  Good job, however, you have to do some work on the view on mobile and tab. The layout gets disorganised as I shrink to smaller deevices

  Marked as helpful

  0
• 

  T

  Matt Studdert•13,611

  @mattstuddertPosted over 3 years ago

  Hey Livana, congrats on completing your first challenge! Did you learn anything new while working through it?

  For the image, you need to add display: block; to remove the gap at the bottom. It's a quirk with images whereby you often need to add display: block; because of that issue.

  Be sure to check out the accessibility report. At the moment, you're missing the alt attribute on the img element. This will make screen readers read out the file path, which isn't helpful. You can either add descriptive text in the alt attribute or if you feel the image doesn't add context to the content, you can leave it blank like this: alt="". That will ensure screen readers skip the image.

  Also, I'd say the numbers in the stats aren't headings. Instead, you could change them to span elements to style them differently. The fact you've used a list is great, as it is technically a list of stats.

  I hope that helps! Let me know if you have any questions 🙂

  Marked as helpful

  0