Design comparison
Solution retrospective
Your feedback who be much appreciated.
Community feedback
- @oluwa-busssy-olamiPosted about 2 years ago
Thank you so much, but it’s not mobile responsive. kindly put me through.
0 - @DavidMorgadePosted about 2 years ago
Hello Busoalmi, congrats on completing the solution for this challenge!
If you don't mind, I would like to give you some advice.
First of all , try to use a bit more semantic tags in your html, for example, instead of having directly a
div
tag, you could have amain
divided insection
tags, always try to use more semantics html tags cause they will give a better accesibility to people that uses screen readers and also it will position your site better on search engines.Apart from that, the only problem I find in your CSS is that when going to lower than 600px, it brokes a bit the layout, you can fix this adding a
grid-template-columns: 95%;
to give it a flexible width to your grid, you should use it on a media querie so the desktop layout doesn't change!Hope my feedback helps you, if you have any questions don't hesitate to ask!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord