Static-job-listing using React and SCSS. This is my first ever React

Community feedback

• 

  David Omar•580

  @davidomarfPosted about 4 years ago

  Hey Militus.

  I like the layout. You replicated it pretty well. And I like how it adapts every element to all widths without being funny-looking.

  I only noticed that the tags section is bugged. It displays the language list as a single string: Frontend, Senior, HTMLCSSJavaScript, HTML, CSS, JavaScript.

  I found the line that causes this. It's this one: https://github.com/MilitusInnocent/static-job-listing/blob/master/src/jobBoard.js#L20

  You're adding the languages twice. One as an array, and one more as a spread array.

  The only other thing I'd do would be working on the shadows. It looks very dark and strong.

  Try with the darker blue. The same that you used in the tags text. And give it a little bit more of blur.

  2

  ---

  

  Militus Innocent•555

  @MilitusInnocentPosted about 4 years ago

  @davidomarf thanks a bunch! I just saw the language stuff, I'd get it done right away. Thanks so much. I'd look at the color too..

  0
• 

  Abdulla Bashiroglu•520

  @bashirogluPosted about 4 years ago

  looks great, in order to be more productive and have a maintainable code, you can put components to folders and add scss files directly to components. So in that case you will know which scss code is where. But they will be compiled, so don't use the same className 2 different file.

  2

  ---

  

  Militus Innocent•555

  @MilitusInnocentPosted about 4 years ago

  @bashiroglu thank you so much! I'd look into it. I really appreciate

  0
• 

  Justin Punzalan•535

  @justAdevTVPosted about 4 years ago

  Hey Militus,

  Great work overall! Your live example works well on my desktop and my phone :)

  I see that you used React to make your project too.

  I made mine with NextJS (React SSR) & styled-components instead. I'd love to know your thoughts on my approach if you have time.

  Check it out here: https://www.frontendmentor.io/solutions/near-perfect-pixels-11-w-nextjs-and-styledcomponents-FYfg1bDZY

  1

  ---

  

  Militus Innocent•555

  @MilitusInnocentPosted about 4 years ago

  @justAdevTV definitely! My first time hearing NEXTJS

  0

  

  Justin Punzalan•535

  @justAdevTVPosted about 4 years ago

  @MilitusInnocent Awesome!

  0

  

  Militus Innocent•555

  @MilitusInnocentPosted about 4 years ago

  @justAdevTV I'd definitely look it up.

  1