Static site using Sass and BEM

Community feedback

• 

  Ahmed Faisal•5,095

  @afrusselPosted over 3 years ago

  Wow nice work. So close to design. Great

  Marked as helpful

  2

  ---

  

  Haziq•320

  @zyq-mPosted over 3 years ago

  @afrussel Thank you Ahmed. Could you please take a look why there is accessibility issues occur?

  0
• 

  Haziq•320

  @zyq-mPosted over 3 years ago

  Can somebody help me explain the accessibility issues? I don't understand why this happened.

  0

  ---

  

  Carlos E Alford•285

  @webshurikenPosted about 3 years ago

  @zyq-m Hi, well done on the card! Looks great. I had a look at your accessibility issues and it is to do with how you used your HTML elements. Issue 1: Is to do with the order in which the heading elements appear in your document. You used the <h3> right after the <h1> which is not recommended. It should be:

  <h1>Main title</h1>
    <h2>Secondary</h2>
      <h3>...</h3>
  

  Issue 2-3: are related to each other. This is to do with assistive technologies and how they read the document. You need to use landmarks like <nav> or <main> and place your tags inside of them..

  So if you wrap your <section class="card"> with the <main> tag it should solve the last two issues.

  best explained here:

  • webdev landmarks

  Also here it tells you how to use the landmarks:

  • MDN content sectioning

  Hope this helps Hazlq and Happy Coding :-)

  0