More important than anything else though - you need to change the html in this!
- You can only have one
main
per page. That's not just recommended, it's an essential accessibility requirement - The
header
element has a role of "banner" and has a very specific purpose to contain repeating content across a site such as logo and navigation. There is no header in this design as it's a single component, not a full Web page. You are trying to use it here as a heading element. For that you must use a heading element. - Similar, you are using footer incorrectly here. There is nothing in the design that would be appropriate footer content. The content in the first half is just paragraphs and in the second part of the component should only be a button. Note for future challenges, you can have multiple footers or navigations on a single page but this is unusual, and if you did that, you'd have to label both of them in order to meet accessibility requirements
- I'm a little confused reading the html of the results list... I don't think it's wrong, that's not what I'm saying... It just feels overly complicated as I'm reading it, maybe because of the div in there. List items are already meaningful elements, so you don't need any paragraphs inside... If only expect to see the text parts inside wrapped in spans. OR the title of each result like "memory" could be a heading then the results number a paragraph I think. OR you could use a description list instead for all of this content as that element is specifically designed for key-value pairs like this.
General recommendations:
- it's better for performance usually to include the reset at the top of your css rather than.load a separate asset
- it's usually better for performance to load the fonts in the html head instead of within the CSS @imports
- height 100vh should be min-height as already suggested
- never ever write font size in pixels! here is my blog about why
- always define media queries in rem or em, never pixels
- next time work mobile first
- it looks like you've already used the max width approach on the component so maybe I misunderstood your question in my previous answer, I'm not sure. Making the max width into rem would still improve it though
Marked as helpful