Static QR-Code

Community feedback

• 

  Hassia Issah•50,650

  @HassiaiPosted almost 2 years ago

  Replace <div class="component"> with the main tag, <p class="heading"> with <h1> to fix the accessibility issue. click here for more on web-accessibility and semantic html

  The body has a wrong background-color, Use the colors that were given in the styleguide.md found in the zip folder you downloaded.

  To center .component on the page using flexbox, replace the height in the body with min-height: 100vh. Give the img a max-width of 100% instead of a height.

  Give h1 and p the same font-size of 15px and the same margin-left, margin-right and margin-top values. Give p a margin bottom value.

  Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here

  Hope am helpful.

  Well done for completing this challenge. HAPPY CODING

  Marked as helpful

  1

  ---

  

  eskevv•30

  @eskevvPosted almost 2 years ago

  @Hassiai thank you! That explains a lot of what I was trying to do just wasn’t sure. Also are you sure the background color is still wrong? I updated it so it should look the same color now

  1

  

  Hassia Issah•50,650

  @HassiaiPosted almost 2 years ago

  @eskevv yes

  0