Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Static QR Code Component Page

@lucasricci

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


I have a few question regarding my code and its readability:

  • Is there something I am overengeneering in the code, like writting more to do the same thing;
  • Is the code well readable? Or it is a little nested?
  • Tips in how to center and move objects on CSS, this is one of things I found the hardest in front-end.

I appreciate any help on these questions or other feedbacks.

Community feedback

ABBA 140

@ABBA-74

Posted

Centering and positioning objects on CSS can be tricky, but there are a few tips that can help:

To center an element horizontally, you can use the margin: 0 auto; property on the element's container. To center an element vertically, you can use the display: flex; and align-items: center; properties on the element's container, or use the position: absolute; and top: 50%; properties on the element itself.

Marked as helpful

1
Ecem Gokdogan 9,380

@ecemgo

Posted

Some recommendations regarding your code that could be of interest to you.

In order to fix the accessibility issues:

  • You need to replace <div class="rectangle"> with the <main class="rectangle"> tag. You'd better use Semantic HTML, and you can also reach more information about it from Using Semantic HTML Tags Correctly.
  • Each main content needs to start with an h1 element. Your accessibility report states page should contain a level-one heading. So, you should use one <h1> element in the <main> tag. You can replace your <h2>Improve your front-end skills by building projects</h2> element with the <h1>Improve your front-end skills by building projects</h1> element.

After committing the changes on GitHub and you need to deploy it as a live site. Finally, you should click generate a new report on this solution page to clear the warnings.

Hope I am helpful. :)

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord