Static job listings master

Community feedback

• 

  Yemisrach•1,430

  @Yemisrach15Posted about 2 years ago

  Hi Aya, great job! A few suggestions I think would be helpful,

  • The 'x' buttons should have a discernible text meaning you should add an aria-label for screen readers.
  • The boxes could be article elements for better semantics.
  • The company logos alt attribute should be descriptive. 'company logo' does not fully describe the images. You could, for instance, say "Photosnap company's logo".
  • The tags in my opinion should be listed in a list, ul, element.

  1

  ---

  

  Aya Saeed•1,020

  @Aya-Saeed261Posted about 2 years ago

  Hey @Yemisrach15, thanks alot for the suggestions! Could you suggest a good source to learn more about semantics especially the article tag, I'm not always sure when to use it

  0

  

  Yemisrach•1,430

  @Yemisrach15Posted about 2 years ago

  w3schools might be a good start. Whenever I'm not sure when to use semantic tags, I search for first its definition on MDN, go through examples, and sometimes inspect the source code of websites. It helps me :)

  0