Static Job Listings (HTML, CSS, JS, jQuery)

Community feedback

• 

  Manik Kapoor•370

  @Manik2375Posted over 2 years ago

  Hi @Ben nice work on animation, I really liked the hiding one, though talking about methodology, I see you are using BEM, but you aren't following it correctly :(

  According to it, element should not contain element, which in your case is .job__description which represents an element contains other elements.

  Nice work btw :thumbs_up:

  0

  ---

  

  Ben•770

  @BenConfigPosted over 2 years ago

  @Manik2375

  Hey, thanks for your feedback.

  According to this, you can use elements inside other elements. They give an example:

  <ul class="lang-switcher">
          <li class="lang-switcher__item">
              <a class="lang-switcher__link" href="url">en</a>
          </li>
          <li class="lang-switcher__item">
              <a class="lang-switcher__link" href="url">ru</a>
          </li>
      </ul>
  

  Am I not understanding this correctly? BEM can be quite confusing.

  0

  

  Manik Kapoor•370

  @Manik2375Posted over 2 years ago

  @BenConfig Oh yeah, haha I got confused it should be by bem's name(i.e. elements can't be nested by names like .lang-switcher__item__something). My bad ;p

  Though I don't have any complaints for design ^-^ Nice work!

  0