Submitted about 3 years ago

static components web page developed by SASS with BEM

Swan-Yee-Tun• 225

@developedBySwan

Preview site(opens in new window)View code(opens in new window)

This is a solution for...

Four card feature section

HTML
CSS

1newbie

View challenge

Design comparison

SolutionDesign

Solution retrospective

I really focus on the CSS grid in this site. This is 2nd project use CSS Grid. Not only that I start use BEM methodology. So, I want your feedback and suggestion of my design. Thanks for your time.

Community feedback

Chamu• 13,110

@ChamuMutezva

Posted about 3 years ago

The site is looking good for devices greater than 375px. For smaller devices some attention is needed
Multiple <h1> elements on one page - Using more than one <h1> is allowed by the HTML specification, but is not considered a best practice. Using only one <h1> is beneficial for screenreader users. extract from mdn
do not skip headings, let your headings ascend in order (h1, h2, h2)

Marked as helpful

Swan-Yee-Tun• 225

@developedBySwan

Posted about 3 years ago

@ChamuMutezva Thanks your feedback is great and awesome. I will fix it. Thanks for your attention and feedback guy.

Patrick• 14,285

@palgramming

Posted about 3 years ago

you need to double check your layout in a browser that is 375px wide
you can use border-top to add the colors to the top your cards

Marked as helpful

Swan-Yee-Tun• 225

@developedBySwan

Posted about 3 years ago

@palgramming Wow Thanks man, I forgot to add border-top color and check to small device. I will fix it. Thank for your time and attention.

Please log in to post a comment

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord