Starting with responsive, with html, css and javascript.

Community feedback

• 

  John Ademoye•235

  @Moyo75Posted over 3 years ago

  On mobile:

  • The elements and text in <div class="boton"></div> should be in one line and 25% discount collapses on some mobile screen sizes like 360px. These elements are also not properly space own on larger screen sizes like 700px. I think part of the problem here is the nesting in <p class="igual dos"></p> and generally the way you lay out <div class="boton"></div> with margin-top: 150px. I suggest putting every element in the same level in <div class="boton"></div> and following the flow of elements in the component design here...

  General:

  • At screen size 1024px, the second p element in <div class="header-footer"></div> and <button>Start my trial</button> seem to overlap. I think max-width could help here

  • Also, the width collapse of <div class="header-principal"></div> at screen size 1024px should be fixed. max-width might also come in handy here.

  • Your slider is not hooked up with the pageviews number and the pricing, as described in the readme file. This feature is missing in your Javascript. The same also applies to your toggle button.

  • You might want to add a reference to yourself as the developer and also to FEM as the source of the challenge.

  Correcting these deficits should make your app look and function more as described in the project requirements. Lemme know what you think!

  2
• 

  Luis Fernando Perez Varajas•210

  @luispv02Posted over 3 years ago

  Thank you very much for the comments, the button and the footer if it was an error, what happens is that I only make the responsive that indicates in the styles (375px and 1440px) in my case my screen is 1366px for which I only do that It looks "Good" for those screens, where I placed the 150px was using an absolute position, since I could not find any way to adjust it in that position. The same I think that in the div equal two, in the paragraph it is not the correct way to do it, but it was the first thing I thought about how to do it. I made the slider button connected to a tag with the commented tag id, but I did not know where the amount is placed, for that reason I did not place it, I still need to understand the readme file. Thanks

  0